Skip to content

Conversation

@1-Bart-1
Copy link
Member

No description provided.

@1-Bart-1 1-Bart-1 marked this pull request as ready for review February 26, 2025 02:40
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 51.78571% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/panel.jl 52.94% 16 Missing ⚠️
src/wing_geometry.jl 47.36% 10 Missing ⚠️
src/solver.jl 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/VortexStepMethod.jl 33.33% <ø> (ø)
src/kite_geometry.jl 88.00% <100.00%> (ø)
src/solver.jl 77.77% <0.00%> (ø)
src/wing_geometry.jl 78.06% <47.36%> (+7.26%) ⬆️
src/panel.jl 62.06% <52.94%> (-4.85%) ⬇️

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 26, 2025 03:10
Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one inline comment, I have the impression you replaced the old benchmark with a new benchmark. It would be better to keep the old benchmark and add the new benchmark, or to create second bench2.jl script for the new benchmark.

Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more remark.

@1-Bart-1 1-Bart-1 merged commit cb43571 into main Feb 26, 2025
@1-Bart-1 1-Bart-1 deleted the performance branch February 26, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants